Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LM Studio rejects Memmy JSON requests because it accepts
response_format.typevaluesjson_schemaortext, while the OpenAI-compatible client always sentjson_object. This caused both memory summary and reflection jobs to fail with HTTP 400.The client now retries this specific compatibility error with
textand remembers that capability for later JSON requests. Explicit response-format overrides remain unchanged, and unrelated 400 responses still fail normally.Validation:
google/gemma-4-e4b: summary and reflection both succeedednpm run test -w @memmy/memory(119 files passed; 1092 tests passed; 1 skipped)npm run lintnpm run typecheck