refactor: connector plugin registry to eliminate parallel connector conflicts

.cursor/skills/review-pr/SKILL.md

@@ -210,7 +210,7 @@ gh pr diff "$PR" --name-only
 | **Connectors** | Follows `docs/adding-a-connector.md`: `Connector` trait, resumable backfill cursor, incremental sync until `CancellationToken` fires, ingest `eprintln!` format `[connector:connection_id] …` | Missing sync contract pieces, ad-hoc persistence outside the store dir, divergent module layout (`auth`, `sync`, `api`, `models`) |
 | **Module layout** | Domain-named modules; large files split into submodules; no `utils.rs`/`helpers.rs` catch-alls | New catch-all modules, logic placed in the wrong crate or layer |
 | **Async & sync** | `tokio` + `CancellationToken` for long-running work; no blocking I/O in async paths | Blocking calls in async without justification; sync loops that ignore cancellation |
-| **Config & models** | Extend existing `ConnectorType`, `ConnectionSettings`, serde patterns in `void-core` | One-off config structs, stringly-typed enums, schema changes without migration tests |
+| **Config & models** | Registry-driven connections: `ConnectorType` string newtype, per-connection `toml::Table` settings, `connectors/<name>.rs` plugin descriptors | Central `ConnectorType` enum, `ConnectionSettings` variants, or schema changes without migration tests |
 | **Database** | Access via `Database` methods in `void-core/src/db/`; migrations tested for data preservation | Raw SQL or schema logic outside `db/`; migration without a preservation test |
 | **HTTP clients** | Test constructor like `with_base_url(...)`; production client separate from parsing helpers | Real network in unit tests; parsing mixed into transport layer |
 | **CLI output** | Existing formatters and JSON envelope shapes; read-path changes may need `insta` snapshots | Ad-hoc printing, breaking JSON contract without snapshot update |

CHANGELOG.md

@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- **Internal** — Connector wiring uses a compile-time plugin registry (`inventory`). `ConnectorType` is a string newtype; connection settings are a generic TOML table. Adding a connector no longer edits ~13 central files. Connection settings are validated at setup reload, sync start, and `void doctor`. Poll intervals are read from `[sync]` via the generic `{id}_poll_interval_secs` keys. No user-facing CLI behavior change.
+- **Internal** — Expanded connector registry tests (validation, build, badges, aliases, debug redaction, poll defaults).
 - **Build** — Bump minimum supported Rust version to 1.95 (required by sysinfo 0.39).
 
 ### Added

Cargo.toml

@@ -65,6 +65,7 @@ url = "2"
 urlencoding = "2"
 dirs = "6"
 sysinfo = "0.39.3"
+inventory = "0.3"
 
 # Testing
 wiremock = "0.6"

crates/void-calendar/src/connector/connector_trait.rs

@@ -8,13 +8,15 @@ use void_core::connector::Connector;
 use void_core::db::Database;
 use void_core::models::*;
 
+use crate::CONNECTOR_ID;
+
 use super::types::CalendarConnector;
 use crate::api::CalendarApiClient;
 
 #[async_trait]
 impl Connector for CalendarConnector {
     fn connector_type(&self) -> ConnectorType {
-        ConnectorType::Calendar
+        ConnectorType::from_static(CONNECTOR_ID)
     }
 
     fn connection_id(&self) -> &str {
@@ -46,7 +48,8 @@ impl Connector for CalendarConnector {
     async fn start_sync(&self, db: Arc<Database>, cancel: CancellationToken) -> anyhow::Result<()> {
         self.initial_sync(&db).await?;
 
-        let mut interval = tokio::time::interval(std::time::Duration::from_secs(60));
+        let mut interval =
+            tokio::time::interval(std::time::Duration::from_secs(self.poll_interval_secs));
         loop {
             tokio::select! {
                 _ = cancel.cancelled() => {
@@ -70,7 +73,7 @@ impl Connector for CalendarConnector {
                     let count = cals.items.as_ref().map(|i| i.len()).unwrap_or(0);
                     Ok(HealthStatus {
                         connection_id: self.connection_id.clone(),
-                        connector_type: ConnectorType::Calendar,
+                        connector_type: ConnectorType::from_static(CONNECTOR_ID),
                         ok: true,
                         message: format!("{count} calendar(s) accessible"),
                         last_sync: None,
@@ -81,7 +84,7 @@ impl Connector for CalendarConnector {
                     warn!(connection_id = %self.connection_id, error = %e, "Calendar health check API error");
                     Ok(HealthStatus {
                         connection_id: self.connection_id.clone(),
-                        connector_type: ConnectorType::Calendar,
+                        connector_type: ConnectorType::from_static(CONNECTOR_ID),
                         ok: false,
                         message: format!("API error: {e}"),
                         last_sync: None,
@@ -93,7 +96,7 @@ impl Connector for CalendarConnector {
                 warn!(connection_id = %self.connection_id, error = %e, "Calendar health check auth error");
                 Ok(HealthStatus {
                     connection_id: self.connection_id.clone(),
-                    connector_type: ConnectorType::Calendar,
+                    connector_type: ConnectorType::from_static(CONNECTOR_ID),
                     ok: false,
                     message: format!("Auth error: {e}"),
                     last_sync: None,

crates/void-calendar/src/connector/types.rs

@@ -26,6 +26,7 @@ pub struct CalendarConnector {
     pub(crate) credentials_file: Option<String>,
     pub(crate) calendar_ids: Vec<String>,
     pub(crate) store_path: std::path::PathBuf,
+    pub(crate) poll_interval_secs: u64,
 }
 
 impl CalendarConnector {
@@ -34,6 +35,7 @@ impl CalendarConnector {
         credentials_file: Option<&str>,
         calendar_ids: Vec<String>,
         store_path: &std::path::Path,
+        poll_interval_secs: u64,
     ) -> Self {
         Self {
             connection_id: connection_id.to_string(),
@@ -44,6 +46,7 @@ impl CalendarConnector {
                 calendar_ids
             },
             store_path: store_path.to_path_buf(),
+            poll_interval_secs,
         }
     }
 }

crates/void-calendar/src/lib.rs

@@ -1,3 +1,5 @@
 pub mod api;
 pub mod connector;
 pub mod error;
+
+pub const CONNECTOR_ID: &str = "calendar";

crates/void-cli/Cargo.toml

@@ -34,6 +34,8 @@ libc = { workspace = true }
 croner = { workspace = true }
 sysinfo = { workspace = true }
 uuid = { workspace = true }
+inventory = { workspace = true }
+toml = { workspace = true }
 
 [dev-dependencies]
 assert_cmd = { workspace = true }

crates/void-cli/src/cli.rs

@@ -1,4 +1,4 @@
-use clap::{Parser, Subcommand};
+use clap::{CommandFactory, FromArgMatches, Parser, Subcommand};
 
 use crate::commands;
 use crate::context;
@@ -109,7 +109,10 @@ fn refresh_policy_for_cli(cli: &Cli) -> void_core::store::RefreshPolicy {
 }
 
 pub fn run() -> anyhow::Result<()> {
-    let cli = Cli::parse();
+    let mut cmd = Cli::command();
+    crate::output::patch_connector_arg_help(&mut cmd);
+    let matches = cmd.get_matches();
+    let cli = Cli::from_arg_matches(&matches)?;
 
     let refresh = refresh_policy_for_cli(&cli);
     context::init(