Draft
Conversation
MasterLaplace
added
documentation
6 tasks
docs(.github): put the correct name of the project
…fast flag in Libs's makefile
12 Implement Laplace Library
13 Implement Laplace Launcher
…gement 17 Implement a Version Management
feat(Engine): Clock, Window, Config, Math and Engine module implemented
MasterLaplace
force-pushed
the
9-create-a-complete-new-architecture
branch
from
667dbe7 to
b4a1296
Compare
MasterLaplace
commented
Oct 18, 2023
MasterLaplace
commented
Oct 18, 2023
MasterLaplace
commented
Oct 18, 2023
MasterLaplace
commented
Oct 18, 2023
MasterLaplace
commented
Oct 18, 2023
MasterLaplace
commented
Oct 18, 2023
MasterLaplace
commented
Oct 18, 2023
Owner
Author
There was a problem hiding this comment.
need to be fill with the content of the Engine-3D version 0.1.0
MasterLaplace
commented
Oct 18, 2023
MasterLaplace
temporarily deployed
to
github-pages
MasterLaplace
temporarily deployed
to
github-pages
MasterLaplace
temporarily deployed
to
github-pages
MasterLaplace
temporarily deployed
to
github-pages
MasterLaplace
commented
Oct 20, 2023
MasterLaplace
force-pushed
the
9-create-a-complete-new-architecture
branch
from
85c95fb to
7b23dda
Compare
MasterLaplace
force-pushed
the
9-create-a-complete-new-architecture
branch
from
a36c45f to
3be09a5
Compare
MasterLaplace
force-pushed
the
9-create-a-complete-new-architecture
branch
from
3be09a5 to
7b23dda
Compare
…e-new-architecture fix(libs): fix build error
Sigmanificient
requested changes
Nov 12, 2023
Comment on lines
+13
to
+23
| matrix4f matrix4_f_mul(matrix4f m, matrix4f n) | ||
| { | ||
| matrix4f o = MATRIX4F_DEFAULT; | ||
|
|
||
| for (unsigned i = 0; i < 4; i++) | ||
| for (unsigned j = 0; j < 4; j++) | ||
| for (unsigned k = 0; k < 4; k++) | ||
| o.m[i][j] += m.m[i][k] * n.m[k][j]; | ||
|
|
||
| return o; | ||
| } |
Collaborator
There was a problem hiding this comment.
If you are doing a lot of matrix computation, it may be worth taking a look at a faster algorithm, here is a nice resource
| int main(int ac, const char *av[]) { | ||
| #endif | ||
| // Initialize the game engine and its components. | ||
| if (ac != 2) { |
Collaborator
There was a problem hiding this comment.
ac is undefined in windows context?
|
|
||
| #ifndef LAPLACE_LIB_H_ | ||
| #define LAPLACE_LIB_H_ | ||
| #define auto_clean __attribute__((cleanup(laplace_lib_free))) |
Collaborator
There was a problem hiding this comment.
isn't auto_clean only supported by GCC?
| //////////////////////////////////////////////////////////// | ||
| // Define the LAPLACE_LIB version string | ||
| //////////////////////////////////////////////////////////// | ||
| #define LAPLACE_LIB_VERSION_STRING "1.0.0" |
Collaborator
There was a problem hiding this comment.
You can use the glue operator to build the library version string
Suggested change
| #define LAPLACE_LIB_VERSION_STRING "1.0.0" | |
| #define CAT(x) #x | |
| #define XCAT(x) CAT(x) | |
| #define LAPLACE_LIB_VERSION_STR \ | |
| XCAT(LAPLACE_LIB_VERSION_MAJOR) \ | |
| "." XCAT(LAPLACE_LIB_VERSION_MINOR) \ | |
| "." XCAT(LAPLACE_LIB_VERSION_PATCH) |
|
|
||
| inline int laplace_lib_open_file(char const *filepath, unsigned oflag) | ||
| { | ||
| int fd = open(filepath, oflag); |
Collaborator
There was a problem hiding this comment.
the file descriptor should be checker prior to the access call
| } link_t; | ||
|
|
||
| //* It creates a link with the object passed in parameter. | ||
| extern link_t *laplace_link_create(void *_new); |
Collaborator
There was a problem hiding this comment.
Why are they marked as external symbols?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance criteria