test: make runtime-honesty docstring count-free (re-audit residual)#58
Merged
Conversation
TestClaimHonesty.test_suite_runtime_claim_is_honest carried a hardcoded '(334 tests)' in its docstring. The test asserts the README's ~5-10s runtime claim; the exact test count is irrelevant to what it checks and rots the moment the suite grows (it already had). Drop the number and say why, so the docstring can't drift out of date again. Docstring-only: no behavioral change; the 5 TestClaimHonesty assertions still pass, ruff check / ruff format --check clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The re-audit flagged that
TestClaimHonesty.test_suite_runtime_claim_is_honesthardcoded(334 tests)in its docstring — a count that is irrelevant to what the test asserts (the README's ~5-10 s runtime claim) and had already rotted.Change: docstring-only. Removes the count and states why it's deliberately count-free so it can't drift again. No behavioral change.
Verification (local, tooling matches CI):
ruff format --check .→ 42 files already formatted (exit 0)ruff check .→ All checks passedpytest tests/test_app_smoke.py::TestClaimHonesty→ 5 passedAuthored by MarwaBS.