fix(web): handle empty job run history - #3117
Open
Hanabi9248 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #3115.
JobRunItemthrows whenlatestRunsis empty because its reduction has no initial value. A history containing only zero-duration runs also producesNaNbar heights.Solution
Reduce to the maximum duration starting at zero, and use zero height when there is no positive duration. The existing minimum bar height still applies. Normal histories keep their relative bar heights and display order.
Added component tests for empty histories, one run, zero-duration runs, and mixed durations, including preservation of the input order. The empty and zero-duration cases fail on the original component.
Validation
tsc --noEmit, scoped ESLint, and test formatting checks passed.react-routererrors on both this branch and unchanged main (180f37b). Tested with Node 24,npm ci --legacy-peer-deps; Jest usedNODE_PATH=node_modules/jest/node_modulesto resolve the installedjest-utilpeer.One-line summary: Fix dashboard rendering for jobs with empty or zero-duration run histories.
Checklist