-
Notifications
You must be signed in to change notification settings - Fork 142
Card Stack ticks all by default #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Card Stack ticks all by default #2793
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2793 +/- ##
==========================================
+ Coverage 71.72% 71.77% +0.05%
==========================================
Files 134 134
Lines 7299 7305 +6
Branches 1556 1495 -61
==========================================
+ Hits 5235 5243 +8
- Misses 1937 2016 +79
+ Partials 127 46 -81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Perhaps we can make the Otherwise, we can do the opposite, by supporting a way to disable the select all button |
|
@MoshiMoshiMochi If there are non-trivial UX changes, also provide screenshots of those changes. |
What is the purpose of this pull request?
resolves #2781
Overview of changes:
Anything you'd like to highlight/discuss:
cardStackRef.tagMappingto ensure that once the<card>components register their tags, that the parent automatically adds them toselectedTags. SinceselectedTagsis now populated on load, all tags appear checked to begin with.2.1 It can be used to toggle all tags to clear/select all tags in
2.2 It syncs with all the selected tags, meaning that unchecking a single tag automatically unchecks "Select All". This is to better signify that not all tags have been selected.
showAllTags(showTag)to accept a boolean. It now serves as a master switch to loop through all child cards and set their disableTag state to either true (visible) or false (hidden).updateTagso that unchecking all cards now displays no other cards. Previously doing so would automatically display all cards again.See Demo Example
e.g. serving this exampleUserGuide error?
Shouldn't
disablebedisabled? See demo example above for reference. Kindly let me know if I'm mistaken or if I should go ahead and fix this since its so small.markbind/docs/userGuide/syntax/cardstacks.md
Lines 138 to 153 in ca4a65b
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Update Card Stack to tick all tags by default
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):