Skip to content

Conversation

@gerteck
Copy link
Member

@gerteck gerteck commented Feb 14, 2025

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:

Fixes #2595

Compiled js file after running npm run setup or npm run build:backend which compiles ts files into js files through tsc --noEmitOnError not listed to be ignored by git, cuasing some inconvenience especially during development.

Added the compiled js file into both gitignore and eslint ignore.

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)

Update gitignore and eslintignore

Added dangerfile.js compiled from tsc to respective ignores.


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Add to gitignore and eslintignore
@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.86%. Comparing base (4ed8781) to head (b29722b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2601   +/-   ##
=======================================
  Coverage   51.86%   51.86%           
=======================================
  Files         127      127           
  Lines        5474     5474           
  Branches     1201     1201           
=======================================
  Hits         2839     2839           
  Misses       2340     2340           
  Partials      295      295           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lhw-1
Copy link
Contributor

lhw-1 commented Feb 14, 2025

Just to provide more context: Dangerfile.ts was added in #2523 to address #2140. This PR is mainly to fix a small bug arising from Dangerfile.ts needlessly being compiled into .js.

(If there is some missing context, i.e. if this was not an oversight but was intended, feel free to comment further)

Copy link
Contributor

@lhw-1 lhw-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This should make development less annoying for all.

@lhw-1 lhw-1 changed the title Add compiled ts dangerfile.js to ignore Add compiled dangerfile.js to .gitignore and .eslintignore Feb 14, 2025
@lhw-1 lhw-1 merged commit 92d2373 into MarkBind:master Feb 14, 2025
9 checks passed
lhw-1 added a commit that referenced this pull request Feb 14, 2025
@github-actions
Copy link

@lhw-1 Each PR must have a SEMVER impact label, please remember to label the PR properly.

@lhw-1 lhw-1 added the r.Patch Version resolver: increment by 0.0.1 label Feb 14, 2025
@lhw-1 lhw-1 added this to the v5.6.0 milestone Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r.Patch Version resolver: increment by 0.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update .eslintignore, .gitignore for dangerfile.js (from dangerfile.ts)

2 participants