Remove stale text initial maze prompt strategy#26
Closed
helenlu66 wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Closing per request; the stale prompt strategy removals are being undone. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated text_initial_maze prompting option and associated prompt strategy, simplifying prompt-strategy selection and runner prompt plumbing.
Changes:
- Dropped
text_initial_mazefromExperimentConfig.promptingand removed its strategy class. - Simplified
ExperimentRunnerprompt strategy mapping and system-prompt construction. - Reduced runner logging and transcript metadata (notably token-usage capture).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| interface/runner.py | Removes text_initial_maze strategy wiring and simplifies system-prompt / transcript logging. |
| interface/prompt_strategies.py | Deletes TextInitialMazePromptStrategy. |
| interface/config.py | Removes text_initial_maze from the prompting Literal type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
127
to
131
| def build_prompt_message( | ||
| self, | ||
| state, | ||
| last_feedback: str, | ||
| transcript: List[dict], |
Comment on lines
206
to
207
| t_llm = time.perf_counter() | ||
| model_text = agent(agent_messages) |
Comment on lines
+224
to
+239
| transcript.append( | ||
| { | ||
| "kind": "query", | ||
| "query_index": query_count, | ||
| "env_step_count": state.step_count, | ||
| "agent_messages": copy.deepcopy(agent_messages), | ||
| "assistant_reply": model_text, | ||
| "parsed_actions": list(action_queue), | ||
| "parse_ok": bool(action_queue), | ||
| "has_image": has_image, | ||
| "llm_latency_s": llm_s, | ||
| "chat_history_mode": chat_history, | ||
| "agent_message_count": len(agent_messages), | ||
| "actions_remaining_before_step": len(action_queue), | ||
| } | ||
| ) |
Member
Author
|
Reopening with the requested approach: keep stale prompt strategy removal, but restore initial maze text in ExperimentRunner._build_message for text_only and image_text. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests