Controller MCL support#15
Open
CodingMantisUA wants to merge 1 commit into
Open
Conversation
CodingMantisUA
force-pushed
the
controller-mcl-support
branch
from
da8b4cb to
aa5694f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added MCL-family specific fields. Added dropping of inventory on controller braking. Explosion support. Hopper support. Screwdriver support.
Added
meseconsupport for VL. Now comparator emits redstone signal, if inventory is non empty. MCLA has their own redstone implementation, and it does not provide API.Look at it as a template to add support for other nodes in the future. I made
apply_controller_game_fieldsfunction to fill definition with game specific fields/methods.Given that it's hard to differentiate between VL and MCLA, I think I won't differentiate between them much. Unless it is actively harmful.
If general principal is OK, I'll move apply same to other nodes.
While on the subject of compatibility, do you have thoughts on material compatibility? Given that MTG is not developed any more, most of new features won't be available there. Should I convert definitions to be MCL first and derive MTG values from there? Seems like there are no derived mods yet.