Skip to content

fix(common-lint): resolve clang-format version from submodule - #817

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/common-lint/clang-format-version
Jul 28, 2026
Merged

fix(common-lint): resolve clang-format version from submodule#817
ReenigneArcher merged 1 commit into
masterfrom
fix/common-lint/clang-format-version

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Replace the hardcoded CLANG_FORMAT_VERSION env var with a dynamic resolution step that reads the pinned clang-format version from the lizardbyte-common submodule's pyproject.toml. Falls back to the latest version with a warning if the submodule or pin is unavailable.

Also replaces the DoozyX/clang-format-lint-action with a direct clang-format shell invocation for the diff step, removing the dependency on that third-party action.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Replace the hardcoded CLANG_FORMAT_VERSION env var with a dynamic resolution step that reads the pinned clang-format version from the lizardbyte-common submodule's pyproject.toml. Falls back to the latest version with a warning if the submodule or pin is unavailable.

Also replaces the DoozyX/clang-format-lint-action with a direct clang-format shell invocation for the diff step, removing the dependency on that third-party action.
@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher marked this pull request as ready for review July 28, 2026 01:52
@ReenigneArcher
ReenigneArcher merged commit 6f28853 into master Jul 28, 2026
18 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/common-lint/clang-format-version branch July 28, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant