Repository navigation
feat(standings): allow setting definite status from a given round - #8186
Merged
Merged
Conversation
Editors can set `rXbg=<status>` on an opponent to mark it as definitely qualified/eliminated from round X onwards, before the stage is finished. Multiple can be given; each round uses the one with the highest X not after it. - Sets both definite and current status, so row and label stay consistent - Overrides the bg-derived definite status of finished standings; disqualifications still override it - The parser resolves the status from `definiteStatuses` on the opponent data, so automatic detection can fill the same field later Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Maps the legacy `r<round>bg<team>` input to `r<round>bg` on the opponent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is consistent across parsing and application paths, with focused coverage for boundaries and disqualification precedence.
0 open findings
What changed in this PR
Adds round-based manual definitive statuses to standings, including legacy Swiss input support and tests.
Changes:
- Parses
r<round>bgstatuses and applies them from the specified round onward. - Preserves disqualification precedence.
- Adds parser, wiki-input, and legacy Swiss coverage.
| File | Description |
|---|---|
lua/wikis/commons/Standings/Table/Legacy/Swiss.lua |
Maps legacy team status inputs. |
lua/wikis/commons/Standings/Table.lua |
Documents the new opponent field. |
lua/wikis/commons/Standings/Parser.lua |
Resolves and applies manual statuses. |
lua/wikis/commons/Standings/Parse/Wiki.lua |
Parses round-based status inputs. |
lua/spec/standings_parser_spec.lua |
Tests status application and precedence. |
lua/spec/standings_parse_wiki_spec.lua |
Tests wiki-input parsing. |
lua/spec/standings_legacy_swiss_spec.lua |
Tests legacy input mapping. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
hjpalpha
approved these changes
Oct 8, 2026
…finite-status-611cef # Conflicts: # lua/wikis/commons/Standings/Table/Legacy/Swiss.lua
hjpalpha
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Certain teams or players may have their final position type ("up"/"down," etc.) known before all rounds have been played. Currently, we only apply it once the final round is finished, but this PR allows an editor to manually set the status ahead of time.
How did you test this change?
busted and dev