Skip to content

feat(standings): Support Solo in Legacy Swiss Mapper - #8179

Merged
Rathoz merged 5 commits into
mainfrom
legacy-solo
Oct 8, 2026
Merged

Rathoz merged 5 commits into
mainfrom
legacy-solo

Conversation

@Rathoz

@Rathoz Rathoz commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Summary

Add support for legacy simple solo swiss (https://liquipedia.net/rocketleague/Module:SwissTableLeague/solo).

Also add support for DQ in legacy mapping

How did you test this change?

dev on RL

Copilot AI balanced review requested due to automatic review settings October 7, 2026 16:44
@Rathoz
Rathoz requested review from a team as code owners October 7, 2026 16:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Disqualification inputs are ignored by the downstream parser, and numeric disqualification rounds are discarded.

2 open findings
What changed in this PR

Extends the legacy Swiss standings mapper to support solo competitors and disqualification inputs.

Changes:

  • Selects solo or team parsing based on opptype.
  • Shares tiebreaker, starting-point, and disqualification input handling.
File Description
lua/​wikis/​commons/​Standings/​Table/​Legacy/​Swiss.lua Adds solo parsing and shared disqualification mapping.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lua/wikis/commons/Standings/Table/Legacy/Swiss.lua Outdated
Comment thread lua/wikis/commons/Standings/Table/Legacy/Swiss.lua Outdated
@hjpalpha

hjpalpha commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

did you mean to link https://liquipedia.net/rocketleague/Module:SwissTableLeague/solo in the description?
(the one you linked is not solo but team based)

@hjpalpha

hjpalpha commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

on phone but don't see the following getting mapped:

  • pX (same treatment as playerX)
  • playerXflag/pXflag
  • playerXlink/pXlink
  • playerXalias/pXalias

@Rathoz

Rathoz commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

on phone but don't see the following getting mapped:

  • pX (same treatment as playerX)
  • playerXflag/pXflag
  • playerXlink/pXlink
  • playerXalias/pXalias

weren't in teh docs (for the one I'm creating legacy support for atm, which is RL solo). Aliases I think is unused (at least it is on LR)

@hjpalpha

hjpalpha commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

on phone but don't see the following getting mapped:

  • pX (same treatment as playerX)
  • playerXflag/pXflag
  • playerXlink/pXlink
  • playerXalias/pXalias

weren't in teh docs (for the one I'm creating legacy support for atm, which is RL solo). Aliases I think is unused (at least it is on LR)

they are in the code of the old module :P

@Rathoz

Rathoz commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

on phone but don't see the following getting mapped:

  • pX (same treatment as playerX)
  • playerXflag/pXflag
  • playerXlink/pXlink
  • playerXalias/pXalias

weren't in teh docs (for the one I'm creating legacy support for atm, which is RL solo). Aliases I think is unused (at least it is on LR)

they are in the code of the old module :P

yeah hence I added the non-alias one, I still don't see a need for player aliases. I was just reading the docs

@Rathoz
Rathoz requested a review from hjpalpha October 8, 2026 08:44
@Rathoz
Rathoz merged commit 0074775 into main Oct 8, 2026
9 checks passed
@Rathoz
Rathoz deleted the legacy-solo branch October 8, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants