Skip to content

feat(participantTable): support seedlist with faction mode - #8133

Merged
Rathoz merged 7 commits into
mainfrom
feat-seed-table-support-for-faction-participant-table
Oct 7, 2026
Merged

Rathoz merged 7 commits into
mainfrom
feat-seed-table-support-for-faction-participant-table

Conversation

@hjpalpha

@hjpalpha hjpalpha commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • support seedlist with faction mode
  • rework display to be closer to table2
  • move buttons on top of the table instead of in the title row
  • kick some unused scss and js (checked per insource-search across wikis via fo's tool page)

How did you test this change?

test cases and dev
https://liquipedia.net/starcraft2/User:Hjpalpha/wip33

@hjpalpha
hjpalpha added this pull request to stack #8119 September 26, 2026 11:38
@hjpalpha
hjpalpha marked this pull request as ready for review September 26, 2026 12:37
@hjpalpha
hjpalpha requested review from a team as code owners September 26, 2026 12:37

@mbergen mbergen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd also have a golden test that shows the seed list, but OOS for this

Comment thread lua/wikis/commons/Features/ParticipantTable/Controller.lua Outdated
@hjpalpha
hjpalpha requested a review from mbergen September 27, 2026 17:34
@Rathoz
Rathoz force-pushed the feat-seed-table-support-for-faction-participant-table branch from 049a87c to e03b3d3 Compare October 2, 2026 13:59
@hjpalpha
hjpalpha force-pushed the feat-seed-table-support-for-faction-participant-table branch 3 times, most recently from 8655cf3 to 47ea85b Compare October 4, 2026 06:50
@Rathoz
Rathoz force-pushed the feat-seed-table-support-for-faction-participant-table branch from 47ea85b to 6b0a6f9 Compare October 5, 2026 10:51
@hjpalpha
hjpalpha force-pushed the feat-seed-table-support-for-faction-participant-table branch from 6b0a6f9 to cb68268 Compare October 5, 2026 13:20
@Rathoz
Rathoz force-pushed the feat-seed-table-support-for-faction-participant-table branch from cb68268 to 459c501 Compare October 7, 2026 08:12

@Rathoz Rathoz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any perticular reason table2 can't be used?

Base automatically changed from refactor-partTable-8 to main October 7, 2026 08:17
@Rathoz
Rathoz force-pushed the feat-seed-table-support-for-faction-participant-table branch from 459c501 to ddcc302 Compare October 7, 2026 08:17
@hjpalpha

hjpalpha commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator Author

Any perticular reason table2 can't be used?

for the seedlist only or for the partTable itself too?

for the seedlist we could change it to that probably
for the faction partTable probably too

for the non-faction partTable i doubt it since there is the width and flex handling in play

if you want i can test stuff out, but would prefer to do so in a stacked PR on #8165

@Rathoz

Rathoz commented Oct 7, 2026

Copy link
Copy Markdown
Member

You can make it on a stacked, that's fine

@hjpalpha

hjpalpha commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

You can make it on a stacked, that's fine

#8173
(only for faction mode and seedlist though, as for the "normal" one it is not usable without breaking the flex stuff)

@Rathoz
Rathoz merged commit 11ba75b into main Oct 7, 2026
8 checks passed
@Rathoz
Rathoz deleted the feat-seed-table-support-for-faction-participant-table branch October 7, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants