Repository navigation
feat(participantTable): support seedlist with faction mode - #8133
Conversation
mbergen
left a comment
There was a problem hiding this comment.
Ideally we'd also have a golden test that shows the seed list, but OOS for this
049a87c to
e03b3d3
Compare
8655cf3 to
47ea85b
Compare
47ea85b to
6b0a6f9
Compare
6b0a6f9 to
cb68268
Compare
cb68268 to
459c501
Compare
Rathoz
left a comment
There was a problem hiding this comment.
Any perticular reason table2 can't be used?
459c501 to
ddcc302
Compare
for the seedlist only or for the partTable itself too? for the seedlist we could change it to that probably for the non-faction partTable i doubt it since there is the width and flex handling in play if you want i can test stuff out, but would prefer to do so in a stacked PR on #8165 |
|
You can make it on a stacked, that's fine |
#8173 |
Summary
How did you test this change?
test cases and dev
https://liquipedia.net/starcraft2/User:Hjpalpha/wip33