Skip to content

feat(match2): reduce number of bans generated in deadlock copypaste #8027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rathoz merged 7 commits into from
Sep 16, 2026
Merged

feat(match2): reduce number of bans generated in deadlock copypaste #8027

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
238d63a
Reduce ban size to 2
Corsaka Aug 31, 2026
0b4793f
feat(match2): customizable ban number in deadlock copypaste
Corsaka Sep 1, 2026
504e8c7
@Corsaka feat(match2): fix zero case in deadlock copypaste
Corsaka Sep 1, 2026
75aa8e6
feat(match2): refactor ban changes as functions
Corsaka Sep 9, 2026
eeab158
Merge branch 'main' into patch-1
Corsaka Sep 9, 2026
6abfa13
feat(match2): linting type correction
Corsaka Sep 10, 2026
e13eebe
feat2(match2): apply batched suggestions from code review
Corsaka Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions lua/wikis/deadlock/GetMatchGroupCopyPaste/wiki.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ local INDENT = WikiCopyPaste.Indent

function WikiCopyPaste.getMatchCode(bestof, mode, index, opponents, args)
local showScore = Logic.nilOr(Logic.readBoolOrNil, bestof == 0)
local bans = Logic.readBool(args.bans)
local bans = tonumber(args.bans) or 0

local lines = Array.extend(
'{{Match|bestof=' .. (bestof ~= 0 and bestof or ''),
Expand All @@ -40,17 +40,27 @@ function WikiCopyPaste.getMatchCode(bestof, mode, index, opponents, args)
end

---@param mapIndex integer
---@param bans boolean
---@param bans integer
---@return string
function WikiCopyPaste._getMapCode(mapIndex, bans)
---@param opponentIndex integer
---@return string?
local banText = function(opponentIndex)
if bans <= 0 then
return
end
return INDENT .. INDENT .. table.concat(Array.mapRange(1, bans, function(banIndex)
return '|t' .. opponentIndex .. 'b' .. banIndex .. '='
end))
end
Comment thread
Corsaka marked this conversation as resolved.
return table.concat(Array.extend(
INDENT .. '|map' .. mapIndex .. '={{Map',
INDENT .. INDENT .. '|team1side=',
INDENT .. INDENT .. '|t1h1=|t1h2=|t1h3=|t1h4=|t1h5=|t1h6=',
bans and (INDENT .. INDENT .. '|t1b1=|t1b2=|t1b3=|t1b4=|t1b5=|t1b6=') or nil,
banText(1),
INDENT .. INDENT .. '|team2side=',
INDENT .. INDENT .. '|t2h1=|t2h2=|t2h3=|t2h4=|t2h5=|t2h6=',
bans and (INDENT .. INDENT .. '|t2b1=|t2b2=|t2b3=|t2b4=|t2b5=|t2b6=') or nil,
banText(2),
INDENT .. INDENT .. '|length=|winner=|matchid=|vod=',
INDENT .. '}}'
), '\n')
Expand Down
Loading