Skip to content

feat(TeamParticipants): store role data to LPDB - #8016

Merged
Rathoz merged 3 commits into
mainfrom
team-participant-store-role
Sep 7, 2026
Merged

feat(TeamParticipants): store role data to LPDB#8016
Rathoz merged 3 commits into
mainfrom
team-participant-store-role

Conversation

@ElectricalBoy

@ElectricalBoy ElectricalBoy commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR adds support for storing player roles to placement.opponentplayers from TeamParticipants.

How did you test this change?

preview with dev

@ElectricalBoy
ElectricalBoy requested review from a team as code owners August 28, 2026 05:11
@hjpalpha

hjpalpha commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator
  • why is this needed/wanted
  • could we get length limit issues of the opponentplayers field due to this for cases where there are many players per opponent?

@ElectricalBoy

ElectricalBoy commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

why is this needed/wanted

#8017 depends on this

could we get length limit issues of the opponentplayers field due to this for cases where there are many players per opponent?

placement.opponentplayers doesn't seem to have a length limit specified according to Special:LiquipediaDB?
Might just need to throw role info to placement.extradata if there is a limit 🤷

@hjpalpha

hjpalpha commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

why is this needed/wanted

#8017 depends on this

could we get length limit issues of the opponentplayers field due to this for cases where there are many players per opponent?

placement.opponentplayers doesn't seem to have a length limit specified according to Special:LiquipediaDB? Might just need to throw role info to placement.extradata if there is a limit 🤷

if it has a length limit, it is a pretty big one
the question was about edge cases with e.g. >20 players per team opponent anyways

hjpalpha
hjpalpha approved these changes Aug 28, 2026
View reviewed changes

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise lgtm

@Rathoz
Rathoz merged commit 5a937dc into main Sep 7, 2026
9 checks passed
@Rathoz
Rathoz deleted the team-participant-store-role branch September 7, 2026 08:51
Rathoz added a commit that referenced this pull request Sep 16, 2026
@Rathoz @claude
Merge branch 'main' into bulletproof-1.M
57c6d7e 
Conflict in lua/wikis/commons/MatchGroup/Util.lua: main changed three things
in code this branch moved out. Kept the slim re-export version and migrated
each change to its new home:

- ---@field roles string[]? (#8016) -> standardPlayer in Util/Types.lua
- ---@field submatches MatchGroupUtilSubgroup[] (#7978) -> MatchGroupUtilMatch
  in Util/Types.lua
- match.submatches = groupBySubgroup(match) (#7978) -> MatchUtil.matchFromRecord
  in Util/Match.lua, via MatchUtil rather than the re-export

That last one is load bearing: Util/Starcraft.lua was changed in #7978 to read
match.submatches instead of recomputing it, so dropping the assignment would
have left starcraft submatches empty.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rathoz Rathoz Rathoz approved these changes
@hjpalpha hjpalpha hjpalpha approved these changes

Assignees

No one assigned

Labels

c: team_participant

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ElectricalBoy @hjpalpha @Rathoz