Skip to content

refactor(match2): esports match summary too #8007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Rathoz wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(match2): esports match summary too #8007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 4 additions & 23 deletions lua/wikis/esports/MatchSummary.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@

local Lua = require('Module:Lua')

local Array = Lua.import('Module:Array')
local Countdown = Lua.import('Module:Countdown')
local DateExt = Lua.import('Module:Date/Ext')

local DisplayHelper = Lua.import('Module:MatchGroup/Display/Helper')
local MatchGroupUtil = Lua.import('Module:MatchGroup/Util/Custom')
local MatchSummary = Lua.import('Module:MatchSummary/Base')
Expand All @@ -23,32 +19,17 @@ local IconFa = Lua.import('Module:Widget/Image/Icon/Fontawesome')
local CustomMatchSummary = {}

---@param args table
---@return Widget
---@return Renderable
function CustomMatchSummary.getByMatchId(args)
return MatchSummary.defaultGetByMatchId(CustomMatchSummary, args)
end

---@param match MatchGroupUtilMatch
---@return MatchSummaryBody
function CustomMatchSummary.createBody(match)
local phase = MatchGroupUtil.computeMatchPhase(match)
local showCountdown = (not DateExt.isDefaultTimestamp(match.timestamp)) and phase ~= 'finished'

return MatchSummaryWidgets.Body{children = WidgetUtil.collect(
showCountdown and MatchSummaryWidgets.Row{children = Countdown.create{
date = DateExt.toCountdownArg(match.timestamp, match.timezoneId, match.dateIsExact),
finished = match.finished,
}} or nil,
Array.map(match.games, CustomMatchSummary._createMapRow)
)}
end

---@param game MatchGroupUtilGame
---@return Widget?
function CustomMatchSummary._createMapRow(game)
---@return Renderable?
function CustomMatchSummary.createGame(game)
local gamePhase = MatchGroupUtil.computeMatchPhase(game)

if gamePhase ~='finished' then
if gamePhase ~= 'finished' then
if game.extradata.link == nil then
return MatchSummaryWidgets.Row{
children = MatchSummaryWidgets.GameCenter{children = 'Voting opening soon!'}
Expand Down
Loading