refactor(match2): remove unused customization points - #7970
Merged
Merged
Conversation
Rathoz
force-pushed
the
m2-ms-remove-unused-customization-points
branch
from
August 17, 2026 07:55
6f176e3 to
0b0c3d4
Compare
Rathoz
force-pushed
the
m2-ms-remove-unused-customization-points
branch
2 times, most recently
from
August 17, 2026 08:49
93b9c8a to
ab558e0
Compare
Rathoz
force-pushed
the
m2-ms-remove-unused-customization-points
branch
from
August 17, 2026 08:54
02198aa to
72db0c0
Compare
Rathoz
marked this pull request as ready for review
August 17, 2026 08:59
hjpalpha
approved these changes
Aug 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the shared match summary rendering by removing unused customization hooks for createMatch and createHeader, simplifying the customization surface for match summaries across wikis.
Changes:
- Removed
createHeaderandcreateMatchcustomization points from theCustomMatchSummaryInterfaceflow, always using the base header and base match creation path. - Renamed the base header helper from
createDefaultHeadertocreateHeaderand updated internal call sites accordingly. - Updated Hearthstone’s
MatchSummaryimplementation to call the newMatchSummary.createHeaderand aligned return type annotations toRenderable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/wikis/hearthstone/MatchSummary.lua | Updates Hearthstone match summary to use the new base createHeader API and adjusts type annotations. |
| lua/wikis/commons/MatchSummary/Base.lua | Removes unused header/match customization hooks and standardizes header rendering via MatchSummary.createHeader. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Rathoz
force-pushed
the
m2-ms-remove-unused-customization-points
branch
from
August 17, 2026 09:10
72db0c0 to
085406d
Compare
MischiefCS
pushed a commit
that referenced
this pull request
Sep 24, 2026
* refactor(match2): remove unused customization points * aint fixing this now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
createMatchandcreateHeadercustomization points in match summary.How did you test this change?
trivial