Skip to content

Misusage of Opponent.toName #8061

Description

@Rathoz

There are cases where Opponent.toName cannot be used to uniquely determine an opponent (mostly one-off subteams in a tournament).

Usages of toName:

Bad usage (Will display wrong data):

  • CharacterStats (lookup by toName)
  • PrizePool/Import (groupLastVsAdditionalData keyed by toName)
  • TeamParticipants/Repository (potentialQualifiers serialized with toName)

Questionable usage (highlighting)

  • ParticipantTable (when used for teams, will deduplicate/error on toName)
  • MatchGroup/Display/Helper (hover key)

Ignored usage (sorting)

  • MatchTable (sort key)
  • MatchesScheduleDisplay (sort key)
  • StageWinningsCalculation

Okay usage

  • Opponent (for player teams)

Originally posted by @mbergen in #7448 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions