refactor(routing): extract shared auth+tenant middleware stacks#294
Merged
mikewheeleer merged 2 commits intoJun 19, 2026
Merged
Conversation
- Add src/middleware/stacks.js with authenticatedTenantStack and adminStack - Replace duplicated router.use(authenticateToken, extractTenant) in marketplace.js and invest.js with authenticatedTenantStack - Replace duplicated JWT-or-API-key wiring in auditTrail.js and adminEscrow.js with adminStack via router.use - Mount missing routes in app.js: invest, marketplace, retention, invoiceStateRoutes, adminEscrow, v1 - Fix handleInternalError to honour AppError.status for 4xx responses - Fix getAuditLogs: resolve filtered variable before tenantId filter - Update .gitignore: ignore *.sqlite3, data/, load reports, scratch scripts - Untrack db.sqlite3, fix-invoice.js, parse-ast.js Tests: 27/27 passing, 0 lint errors on impacted files
Contributor
|
clean refactor — pulling the auth + tenant wiring into shared stacks is much nicer to maintain. merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add src/middleware/stacks.js with authenticatedTenantStack and adminStack
Replace duplicated router.use(authenticateToken, extractTenant) in
marketplace.js and invest.js with authenticatedTenantStack
Replace duplicated JWT-or-API-key wiring in auditTrail.js and
adminEscrow.js with adminStack via router.use (removes per-route spread)
Mount missing routes in app.js: invest, marketplace, retention,
invoiceStateRoutes, adminEscrow, v1
Fix handleInternalError to honour AppError.status for 4xx responses
Fix getAuditLogs: resolve filtered variable before tenantId filter
Add limit/offset to knex mock query chain in app.routes.test.js
Mock escrowSubmit, investorCommitment, retentionPurge, contractListRefresh
to prevent transitive import failures in route tests
closes Extract shared route middleware composition to eliminate duplicated auth+tenant wiring #292