wip#190
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 88.31% 88.31%
=======================================
Files 5 5
Lines 77 77
Branches 20 20
=======================================
Hits 68 68
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This work-in-progress pull request modifies the GitHub Actions workflow configuration to temporarily use a feature branch of a reusable workflow for testing purposes. Given the "wip" title, this appears to be an experimental or testing change rather than a production-ready update.
Changes:
- Updated the reference for
reusable_swap_tests.ymlfrom stable version@v1to feature branch@fbe/fix_ragger_tests_swap_condition
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Run swap tests using the reusable workflow | ||
| needs: build_application | ||
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@v1 | ||
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@fbe/fix_ragger_tests_swap_condition |
There was a problem hiding this comment.
This change references a feature branch instead of a stable version tag, which is inconsistent with the established pattern in this codebase. All other reusable workflows from LedgerHQ/ledger-app-workflows use @v1. Using a feature branch name instead of a version tag can introduce instability and unpredictability in the CI/CD pipeline, as the branch can be modified or deleted at any time. If this is intended as a temporary change for testing purposes (suggested by the "wip" PR title), consider documenting the intention to revert this back to @v1 before merging. Otherwise, update this to use a stable version tag that includes the required fixes.
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@fbe/fix_ragger_tests_swap_condition | |
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@v1 |
| name: Run swap tests using the reusable workflow | ||
| needs: build_application | ||
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@v1 | ||
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@fbe/fix_ragger_tests_swap_condition |
There was a problem hiding this comment.
The PR title "wip" (work in progress) suggests this is an incomplete change that should not be merged as-is. Work-in-progress pull requests are typically used for testing or collaboration purposes and should be clearly marked as draft status or have a descriptive title that indicates the intended changes when ready for review.
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@fbe/fix_ragger_tests_swap_condition | |
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@v1 |
No description provided.