Skip to content

wip#190

Open
fbeutin-ledger wants to merge 1 commit into
masterfrom
fbe/test_ci
Open

wip#190
fbeutin-ledger wants to merge 1 commit into
masterfrom
fbe/test_ci

Conversation

@fbeutin-ledger

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Dec 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.31%. Comparing base (d0a02c1) to head (66d6c73).
⚠️ Report is 44 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files           5        5           
  Lines          77       77           
  Branches       20       20           
=======================================
  Hits           68       68           
  Misses          9        9           
Flag Coverage Δ
unittests 88.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This work-in-progress pull request modifies the GitHub Actions workflow configuration to temporarily use a feature branch of a reusable workflow for testing purposes. Given the "wip" title, this appears to be an experimental or testing change rather than a production-ready update.

Changes:

  • Updated the reference for reusable_swap_tests.yml from stable version @v1 to feature branch @fbe/fix_ragger_tests_swap_condition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

name: Run swap tests using the reusable workflow
needs: build_application
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@v1
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@fbe/fix_ragger_tests_swap_condition

Copilot AI Feb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change references a feature branch instead of a stable version tag, which is inconsistent with the established pattern in this codebase. All other reusable workflows from LedgerHQ/ledger-app-workflows use @v1. Using a feature branch name instead of a version tag can introduce instability and unpredictability in the CI/CD pipeline, as the branch can be modified or deleted at any time. If this is intended as a temporary change for testing purposes (suggested by the "wip" PR title), consider documenting the intention to revert this back to @v1 before merging. Otherwise, update this to use a stable version tag that includes the required fixes.

Suggested change
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@fbe/fix_ragger_tests_swap_condition
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@v1

Copilot uses AI. Check for mistakes.
name: Run swap tests using the reusable workflow
needs: build_application
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@v1
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@fbe/fix_ragger_tests_swap_condition

Copilot AI Feb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title "wip" (work in progress) suggests this is an incomplete change that should not be merged as-is. Work-in-progress pull requests are typically used for testing or collaboration purposes and should be clearly marked as draft status or have a descriptive title that indicates the intended changes when ready for review.

Suggested change
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@fbe/fix_ragger_tests_swap_condition
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_swap_tests.yml@v1

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants