Refactor hashCompare to use try-with-resources#860
Open
kayerajava wants to merge 1 commit into
Open
Conversation
Lumine1909
requested changes
May 18, 2026
Lumine1909
left a comment
Member
There was a problem hiding this comment.
Thank you for that pr!
Seems there is an indentation issue, the added lines contain an extra indent.
In addition, the close of the stream parameter in createChecksum can also be deleted:
@NotNull
public static UUID createChecksum(final @NotNull InputStream fis) throws NoSuchAlgorithmException, IOException {
final byte[] buffer = new byte[4096];
final MessageDigest messageDigest = MessageDigest.getInstance("MD5");
int numRead;
do {
numRead = fis.read(buffer);
if (numRead > 0) {
messageDigest.update(buffer, 0, numRead);
}
} while (numRead != -1);
- fis.close();
return UUID.nameUUIDFromBytes(messageDigest.digest());
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapped "FileInputStream" in a try-with-resources block to ensure the stream
is always closed after use, even if an exception occurs.
Prevents file descriptor leaks under heavy load and fixes potential file lock issues on Windows.