fix: merge triple-duplicated createContext/AuthProvider into single export#381
Open
Tinna23 wants to merge 1 commit into
Open
fix: merge triple-duplicated createContext/AuthProvider into single export#381Tinna23 wants to merge 1 commit into
Tinna23 wants to merge 1 commit into
Conversation
…xport - Remove two duplicate createContext declarations and AuthProvider bodies - Keep only the third AuthProvider with the /api/auth/me bootstrap logic - Tighten AuthUser type: id, email, name?, role? - Add useAuth() hook that throws if used outside AuthProvider - Fix double res.json() call (merge artifact) Closes Lead-Studios#359
|
@Tinna23 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves a three-way merge artifact in
src/context/authContext.tsxthat left three separatecreateContextcalls and threeAuthProviderbodies in the same file.Changes
createContextdeclarations and their incompleteAuthProviderbodiesAuthProvider— the one containing the real/api/auth/mebootstrap logicAuthUsertype to{ id, email, name?, role? }matching the issue specuseAuth()hook (throws if called outsideAuthProvider)res.json()call (another merge artifact)useContext(AuthContext)directly outside the new hookTesting
npm run build— zero TypeScript errors introduced by this fileCloses #359