feat: Separate librespot-playback target configuration for Windows … - #24
Merged
Merged
Conversation
…and macOS, and remove default Rodio backend for macOS due to compatibility issues.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the platform-specific dependencies for audio playback in the
Cargo.tomlfile to improve compatibility and stability across Windows and macOS. The changes clarify which audio backend is used on each platform and address known issues with certain backends on macOS.Dependency configuration updates:
librespot-playbackdependency is now explicitly configured with therodio-backendfeature for audio output, ensuring consistent behavior.librespot-playbackdependency is added without specifying a default audio backend, due to known compatibility issues withrodioand CoreAudio/Bluetooth devices. Comments clarify that CI uses theportaudio-backendfeature, and references to related issues are included.