Skip to content

fix: ALSA warnings and lock contention - #18

Merged
LargeModGames merged 1 commit into
LargeModGames:mainfrom
nelivate:fix/17-liked-freeze
Dec 15, 2025
Merged

LargeModGames merged 1 commit into
LargeModGames:mainfrom
nelivate:fix/17-liked-freeze

Conversation

@nelivate

Copy link
Copy Markdown
Contributor

Summary

At least for me personally, the Liked Songs section did not work. I decided to fix it and share the solution with others

Additional information is available in #17 issue

Testing

cargo test --locked:

   Compiling spotatui v0.34.2 (/home/rneller/Projects/spotatui)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 5.00s
     Running unittests src/main.rs (target/debug/deps/spotatui-98d58ab361fe04ee)

running 46 tests
test handlers::common_key_events::tests::test_on_down_press_handler ... ok
test handlers::common_key_events::tests::test_on_up_press_handler ... ok
test handlers::album_list::tests::on_esc ... ok
test handlers::album_tracks::tests::on_esc ... ok
test handlers::album_list::tests::on_left_press ... ok
test handlers::album_tracks::tests::on_left_press ... ok
test handlers::empty::tests::on_down_press ... ok
test handlers::artist::tests::on_esc ... ok
test handlers::empty::tests::on_enter ... ok
test handlers::empty::tests::on_left_press ... ok
test handlers::empty::tests::on_up_press ... ok
test handlers::empty::tests::on_right_press ... ok
test handlers::home::tests::on_large_up_press ... ok
test handlers::home::tests::on_large_down_press ... ok
test handlers::input::tests::test_compute_character_width_with_multiple_characters ... ok
test handlers::home::tests::on_small_down_press ... ok
test handlers::home::tests::on_small_up_press ... ok
test handlers::input::tests::test_input_handler_backspace ... ok
test handlers::input::tests::test_input_handler_clear_input_on_ctrl_l ... ok
test handlers::input::tests::test_input_handler_ctrl_u ... ok
test handlers::input::tests::test_input_handler_ctrl_k ... ok
test handlers::input::tests::test_input_handler_esc_back_to_playlist ... ok
test handlers::input::tests::test_input_handler_delete ... ok
test handlers::input::tests::test_uri_parsing::album ... ok
test handlers::input::tests::test_uri_parsing::artist ... ok
test handlers::input::tests::test_uri_parsing::invalid_format_doesnt_match ... ok
test handlers::input::tests::test_uri_parsing::mismatched_resource_types_do_not_match ... ok
test handlers::input::tests::test_uri_parsing::parse_with_query_parameters ... ok
test handlers::input::tests::test_uri_parsing::playlist ... ok
test handlers::input::tests::test_uri_parsing::show ... ok
test handlers::input::tests::test_uri_parsing::track ... ok
test handlers::playlist::tests::test ... ok
test handlers::input::tests::test_input_handler_on_enter_text_wide_char ... ok
test handlers::input::tests::test_input_handler_left_event ... ok
test handlers::input::tests::test_input_handler_on_enter_text ... ok
test handlers::playbar::tests::on_left_press ... ok
test handlers::input::tests::test_input_handler_on_enter_text_non_english_char ... ok
test handlers::input::tests::test_input_handler_ctrl_w ... ok
test ui::util::tests::display_track_progress_test ... ok
test ui::util::tests::get_track_progress_percentage_test ... ok
test ui::util::tests::millis_to_minutes_test ... ok
test handlers::recently_played::tests::on_esc ... ok
test user_config::tests::parse_theme_item_test ... ok
test user_config::tests::test_parse_key ... ok
test user_config::tests::test_reserved_key ... ok
test handlers::recently_played::tests::on_left_press ... ok

test result: ok. 46 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

@LargeModGames

Copy link
Copy Markdown
Owner

I was aware of these issue. Thank you for fixing it!

@LargeModGames
LargeModGames merged commit 7c55c64 into LargeModGames:main Dec 15, 2025
5 checks passed
@nelivate
nelivate deleted the fix/17-liked-freeze branch December 15, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants