Skip to content

Name the decoded-source cfg predicates with alias features #494

Description

@LargeModGames

Is your feature request related to a problem? Please describe.
About 80 #[cfg(any(feature = "local-files", feature = "subsonic", feature = "qobuz", feature = "youtube"))] attributes across some 20 files spell out "a queueable decoded source is compiled in" by hand, and the five-way variant with internet-radio is exactly feature = "audio-decode". Adding Qobuz meant editing every one of them (#489), and a missed list compiles fine but silently drops that source from one feature combination that no CI leg exercises.

Describe the solution you'd like
One implied feature in Cargo.toml, for example decoded-queue = [], listed inside local-files, subsonic, qobuz, and youtube. The four-way lists become #[cfg(feature = "decoded-queue")] and the five-way lists become #[cfg(feature = "audio-decode")]. A sixth source then touches Cargo.toml and nothing else.

Describe alternatives you've considered
Leaving the lists as they are; the next source repeats the same sweep.

Additional context
Mechanical, no behaviour change; from the review of #489.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions