chore(#620): drop unused stellar-sdk dependency#962
Conversation
|
your branch is green, but it went conflicting after the ci fixes landed on main: #969 and #974 touched backend/Dockerfile and backend/src/workers/soroban-event-worker.ts, which this pr also edits. please rebase on main and it should be good to go: |
Every import in backend/src uses @stellar/stellar-sdk; the bare stellar-sdk package was never referenced and added unnecessary bloat.
95acb29 to
ce76f9d
Compare
|
@ogazboiz You can review now |
ogazboiz
left a comment
There was a problem hiding this comment.
safe removal, the backend imports @stellar/stellar-sdk (v15, a different package) not the bare stellar-sdk@13 you're dropping, and grep confirms zero imports of the bare one. dead dependency. merging.
Closes #620
Summary
stellar-sdkfrombackend/package.json— no file underbackend/srcimports fromstellar-sdk; all imports use@stellar/stellar-sdkpackage-lock.jsonto reflect the removalTest plan
npm run buildpasses inbackend/npm testpasses inbackend/grep -rn "from 'stellar-sdk'" backend/srcreturns nothing