Skip to content

chore(#620): drop unused stellar-sdk dependency#962

Merged
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
Fury03:fix/620-drop-unused-stellar-sdk
Jul 1, 2026
Merged

chore(#620): drop unused stellar-sdk dependency#962
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
Fury03:fix/620-drop-unused-stellar-sdk

Conversation

@Fury03

@Fury03 Fury03 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Closes #620

Summary

  • Removes stellar-sdk from backend/package.json — no file under backend/src imports from stellar-sdk; all imports use @stellar/stellar-sdk
  • Regenerates package-lock.json to reflect the removal

Test plan

  • npm run build passes in backend/
  • npm test passes in backend/
  • Confirm grep -rn "from 'stellar-sdk'" backend/src returns nothing

shogun444 added a commit to shogun444/flowfi that referenced this pull request Jun 30, 2026
@ogazboiz

ogazboiz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

your branch is green, but it went conflicting after the ci fixes landed on main: #969 and #974 touched backend/Dockerfile and backend/src/workers/soroban-event-worker.ts, which this pr also edits. please rebase on main and it should be good to go: git fetch origin && git rebase origin/main && git push --force-with-lease. if any of your Dockerfile or soroban-event-worker changes overlap what #969 already did (copying prisma/ into the runner, and the import type { Prisma } from '../generated/prisma' fix), drop those now-redundant bits and keep just your actual change. i'll re-review and merge once it's rebased and ci is green.

Every import in backend/src uses @stellar/stellar-sdk; the bare stellar-sdk
package was never referenced and added unnecessary bloat.
@Fury03 Fury03 force-pushed the fix/620-drop-unused-stellar-sdk branch 2 times, most recently from 95acb29 to ce76f9d Compare July 1, 2026 10:13
@Fury03

Fury03 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@ogazboiz You can review now

@ogazboiz ogazboiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safe removal, the backend imports @stellar/stellar-sdk (v15, a different package) not the bare stellar-sdk@13 you're dropping, and grep confirms zero imports of the bare one. dead dependency. merging.

@ogazboiz ogazboiz merged commit 150f9eb into LabsCrypt:main Jul 1, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Backend] Drop unused 'stellar-sdk' dependency — code only imports '@stellar/stellar-sdk'

2 participants