Delete search index in an indexing task #7376
Open
+226
−54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
A recent server deadlock involved three concurrent attempts to modify
exp.DataIndexed. Two were admin-initiated requests to delete the index (the second was presumably a retry as it was kicked off 5.5 minutes later), and the third was background indexing of data objects.Additionally, we can capture more context in thread dumps for search indexing tasks.
Changes
LastModifiedto a search task, meaning it will queue and avoid parallel self-executionTasks 📍