Added support for multiple chainsgit#1
Open
belactriple9 wants to merge 1 commit intoLHerskind:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add support for the chains that blockscan.com supports.
a known issue is the blockscan website being able to pull the data but the API not being able to pull the internal transaction data. Without this data, the graph can't be drawn.
A few other QOL additions I made were: changing the etherscan literal to blockscan.com, set port to 80 so I could work on localhost (can be changed back to 3000), commented out calls to .toLowerCase() as they were giving me errors, reformatted server.js to organize the API function calls, and lastly, used public RPCs and rely on the 1/5 second rate limit on the etherscan api.