Repository navigation
ledger: switch to wrpc pack/unpack from wrpc-transport - #279
Open
rvolosatovs wants to merge 1 commit into
Open
rvolosatovs wants to merge 1 commit into
rvolosatovs wants to merge 1 commit into
Conversation
rvolosatovs
added this pull request to stack #272
October 21, 2026 16:17
rvolosatovs
force-pushed
the
roman/ledger/wrpc-pack
branch
2 times, most recently
from
October 21, 2026 17:42
8ac6472 to
89c6af2
Compare
rvolosatovs
marked this pull request as ready for review
October 21, 2026 17:43
rvolosatovs
marked this pull request as draft
October 21, 2026 17:46
Pin wrpc to main a1ad72ea, which folds `wrpc-pack` into `wrpc-transport` (bytecodealliance/wrpc#1553) and adds `pack_ready`, a synchronous `pack` that fails with `WouldBlock` on pending asynchronous values. None of the values the ledger packs contain futures or streams, so use `pack_ready` throughout, which also keeps `Ledger::new` synchronous without polling `pack` by hand. `wrpc-wave` renames `WaveEncoder` to `ValueEncoder`, and `read_value` is now generic over the value type. Assisted-by: anthropic:claude-opus-5-5 Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs
force-pushed
the
roman/ledger/wrpc-pack
branch
from
October 22, 2026 11:53
89c6af2 to
e7ce51e
Compare
rvolosatovs
marked this pull request as ready for review
October 22, 2026 11:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the ledger from
wrpc-packtopack_ready/unpackinwrpc-transport, pinning wrpc tomainat a1ad72ea:packandunpackbytecodealliance/wrpc#1553 moveswrpc-packintowrpc-transport.packis now async there, so packed values can contain futures andstreams.
pack_readybytecodealliance/wrpc#1555 addspack_ready, a synchronouspack. Itfails with
WouldBlockif any asynchronous value is still pending.Nothing the ledger packs (transactions, genesis outputs,
/rpcresults)contains futures or streams, so every call site uses
pack_ready, andLedger::newstays synchronous. Thewrpc-packdependency is dropped.wrpc-waverenamesWaveEncodertoValueEncoder, andread_valueisnow generic over the value type, so the CLI asks for
wasm_wave::value::Valueexplicitly.