You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fetch besu version from CHANGELOG.md instead of latest release tag on main聽#4210
馃攼 馃攼 Should this be a security advisory instead? 馃攼 馃攼
Description
When retrieving the linea-besu version from a besuCommit update, we should fetch the latest besu version declared in the CHANGELOG.md at the besuCommit instead of fetching the latest release tag on main (as the latest besu release tag is not necessary always being tagged at main)
Motivation
Context by our question to Besu team:
Hi Besu team, we're having a release versioning issue from Besu when making a linea-besu release (which builds at a commit hash from besu-eth/besu and set the release version as "the last tag reachable from the commit" plus the "commit hash", e.g.聽 26.8.1-d97cbd6 ), however the issue comes sometimes when we try to make a linea-besu release with a more recent commit on main, e.g. efa817c, and in this case, the release version would become 26.7.0-efa817c, which by telling the semantic version, our external partners or even automatic software deployment tools might get confused and assumes it was a version downgrade, even though it indeed contains all the changes from 26.8.1 plus some other more recent commits. (as the case here)
So our question is how could we do to avoid that in the future? how does your team decide when to release on main (like 26.7.0) and when on branch (like 26.8.1 )? Is there any concerns on always releasing on main ? or is it possible to make a release tag with suffix to indicate a candidate release (e.g. 26.8.1-rc1) for branch releases, and then tag probably as 26.8.1 on main when merging back the release branch to main? any feedback is welcome, thx!
Tasks
Medium-level task that needs to be implemented for this feature request to be considered complete.
Acceptance criteria
List tests that need to be implemented or checks to consider this task completed.
Risks
These are risks that may prevent completion of the task as well as areas to pay special attention to
Remember to
Add the documentation label in case there is an impact on the documentation
Add priority and team labels
Add Task for updating the Runbook or adding/updating existing metrics and alerts.
Activity