Open
Conversation
Collaborator
Author
|
To do:
|
|
@szaman19 for normalizer you can use batchnorm afaiu |
tbennun
requested changes
Mar 26, 2023
tbennun
left a comment
tbennun
left a comment
There was a problem hiding this comment.
Great work! Some comments/questions remain on the model and the files need some standard formatting.
| @@ -0,0 +1,114 @@ | |||
| import lbann | |||
|
|
||
|
|
||
| DATA_CONFIG = configparser.ConfigParser() | ||
| DATA_CONFIG.read("data_config.ini") |
Collaborator
Author
There was a problem hiding this comment.
Ended up including an example file in the example.
| name=None): | ||
|
|
||
| super().__init__() | ||
| MLP.global_count += 1 |
Collaborator
Author
There was a problem hiding this comment.
I usually add it for compute graph visualization and for better debugging messages when things break
| (Layer): Expected shape (Batch, N, self.out_dim) | ||
| """ | ||
| self.instance += 1 | ||
| name = f"{self.name}_instance_{self.instance}" |
| class EdgeProcessor(Module): | ||
| """ Applies MLP transform on concatenated node and edge features | ||
| """ | ||
| global_count = 0 |
Co-authored-by: Tal Ben-Nun <tbennun@users.noreply.github.com>
Add synthetic config file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A partially completed data parallel implementation of
Mesh Graph NetworkPartially completed as the Normalizer operation in the original is currently unsupported, but potentially could be simply added via an external layer. It is similar to Batch Norm but with some slight changes.
Pinging: @bvanessen @tbennun @ndryden