Skip to content

Channels Last Model Memory Format#11

Merged
PatrickRMiles merged 1 commit intoLBANN:mainfrom
michaelmckinsey1:michaelmckinsey1-patch-2
Jan 29, 2026
Merged

Channels Last Model Memory Format#11
PatrickRMiles merged 1 commit intoLBANN:mainfrom
michaelmckinsey1:michaelmckinsey1-patch-2

Conversation

@michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Jan 29, 2026

  • This setting was undone at some point (probably when using FSDP because of a conflict with channels last) and should be torch.channels_last_3d

@michaelmckinsey1 michaelmckinsey1 self-assigned this Jan 29, 2026
PatrickRMiles
PatrickRMiles approved these changes Jan 29, 2026
View reviewed changes
Copy link
Collaborator

@PatrickRMiles PatrickRMiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@PatrickRMiles PatrickRMiles merged commit 909a989 into LBANN:main Jan 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PatrickRMiles PatrickRMiles PatrickRMiles approved these changes

Assignees

@michaelmckinsey1 michaelmckinsey1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelmckinsey1 @PatrickRMiles