refactor(exporter): rename misleading memory metric variables - #27
Merged
sshanks-kx merged 1 commit intoJul 29, 2026
Merged
Conversation
Variable `mem_lim` was assigned to memory_heap_peak_bytes (a peak tracker, not a limit), and `mem_max` was assigned to memory_heap_limit_bytes (a limit, not a max). The names suggested the opposite mapping, creating a maintenance hazard. Fix: rename `mem_lim` -> `mem_peak`, `mem_max` -> `mem_wmax` to match their actual metric meaning.
sshanks-kx
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename local memory metric variables so their names match the metrics they define. This is a readability-only change and does not alter exported metric names.