fix(install): quote install.bat paths and detect architecture - #26
Merged
Merged
Conversation
…rch detection Multiple issues fixed: - Typo "Enviroment" -> "Environment" - EXIT /B without error code returned 0 (success) on failure - Unquoted paths broke with spaces in QHOME - Hardcoded w64 assumed 64-bit; 32-bit installations unsupported - Missing EXIT /B 0 at end of successful run Fix: quote all paths, detect w64/w32 architecture, return proper error codes, fix typo.
sshanks-kx
self-requested a review
July 29, 2026 14:17
sshanks-kx
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden install.bat by quoting QHOME-derived paths, returning non-zero status for fatal preflight failures, and using PROCESSOR_ARCHITECTURE to select the q machine type.