fix(extract): avoid mutating metric values during extraction - #23
Open
belowzeroff wants to merge 1 commit into
Open
fix(extract): avoid mutating metric values during extraction#23belowzeroff wants to merge 1 commit into
belowzeroff wants to merge 1 commit into
Conversation
extractall used `metricvals,:select name,asc each val ...` which upserted sorted values back into the global metricvals table as a side effect of extracting metrics. This mutated shared state during a read operation and caused wasteful re-sorting on every scrape. Fix: sort values inside `summary` (which was missing `asc`) instead of pre-sorting in extractall. histogram already sorted its input. Remove the mutation from extractall entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid in-place mutation of metric values while rendering Prometheus output. This keeps extraction side-effect free for callers that reuse metric state after scraping.