fix(extract): return websocket handler result - #21
Merged
sshanks-kx merged 1 commit intoJul 24, 2026
Conversation
The ws wrapper discarded the return value of the original .z.ws handler by omitting `;res` at the end of the function body. In kdb+, .z.ws can return data to the websocket client. By discarding the return value, all websocket response data was lost. Fix: add `;res` at the end of the ws function body.
sshanks-kx
self-requested a review
July 24, 2026 08:30
sshanks-kx
approved these changes
Jul 24, 2026
Collaborator
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
wshandler was missing;resat the end, unlike all other handlers (pg,ph,pp) which return the result. This caused websocket calls to return null/nothing to the caller.