Review scope of dependencies

[mcollovati]

Some dependencies, almost related to tests, should have a provided scope otherwise they are packaged in war file causing issues at runtime (jar with same classes, jetty jars, etc)

[davidsowerby]

Would this be a krail issue rather than a test app issue?

[mcollovati]

Most of the dependencies that should be changed are defined in testApp.
Maybe also some krail dependency could be reviews (eg make javax.servlet-api compileOnly)

[davidsowerby]

Ok, let's have an issue for each - I'll raise one for Krail

…

On 11 April 2018 at 20:55, Marco Collovati ***@***.***> wrote: Most of the dependencies that should be changed are defined in testApp. Maybe also some krail dependency could be reviews (eg make javax.servlet-api compileOnly) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACEy1u7bYD4P4nm9ID4n_edSjkQydOMHks5tnl-8gaJpZM4TQb5d> .

-- regards David

[mcollovati]

Here a list of dependencies that I think should not be present at runtime; between parenthesis the artifact that defines the dependency: (G) Guava, (K) Krail, (Q3C) q3c Util

animal-sniffer-annotations-1.14.jar (G)
annotations-3.0.0.jar (G)
error_prone_annotations-2.0.18.jar (G)
groovy-all-2.4.9.jar (K)
hamcrest-core-1.3.jar (K)
j2objc-annotations-1.1.jar (G)
javax.servlet-api-3.1.0.jar (K)
junit-4.12.jar (K)
mockito-all-1.10.19.jar (Q3C)
spock-core-1.1-groovy-2.4.jar (K)
spock-guice-1.1-groovy-2.4.jar (K)

In addition there is a duplication

jsoup-1.10.3.jar (Duplicated)
jsoup-1.8.3.jar (Duplicated)

[davidsowerby]

Just wondering how to get around some of the test dependencies - some are there because some of the libraries provide Mocks or other test support classes. (That doesn't explain Spock! - that must be a mistake)

[mcollovati]

Spock is there because it is defined with compile scope in krail build file.
I can open a PR on krail for krail/issues/680 if you want

[davidsowerby]

Sorry, I meant that having test support classes does not explain why Spock in in compile scope :D

No need for PR just doing the changes

[mcollovati]

Ok, sorry for misunderstanding 😄