Repository navigation
[AIR] Fixed typos, grammar and four copy-pasted grammar KDoc links - #2184
Merged
Merged
Conversation
22 small, self-contained fixes: six copy-pasted grammar KDoc links (frameCols, colsOfKind, gather.notNull, all.After), two broken markdown spans, Python-style booleans in NullabilityOptions, and missing articles in slice-row docs, the geo and jupyter comments and apiLevels.md. Produced by Air Automations. Name: Bi-weekly Grammar Nazi / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/a9009d9e-63e7-4730-801c-185f5785b6bd?run=c823a9eb-4516-43b1-b6d0-ae32e6cce51b Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Jolanrensen
self-requested a review
October 23, 2026 13:21
Contributor
Author
There was a problem hiding this comment.
Lovely clean-up — everything checks out, no blocking findings, good to merge from my side.
Produced by Air Automations. Name: AI Review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/8daf2412-0b6c-4433-90c0-b40ab5aebcdb?run=6f84abe0-1cd5-455b-8a85-359637ac4dec
Jolanrensen
approved these changes
Oct 23, 2026
| > or download it [here](https://kotlin.github.io/dataframe/resources/titanic.csv). | ||
|
|
||
| The Extension Properties API provides column names and -types at compile-time, | ||
| The Extension Properties API provides column names and types at compile-time, |
Collaborator
There was a problem hiding this comment.
okay you can remove the dash ffs...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small, self-contained typo / grammar / misleading-documentation fixes found by scanning the repository. 22 fixes across 14 files (37 lines); comments, KDoc and markdown prose only — no code or public signatures changed, so no
apiDumpupdate is needed.Wrong KDoc links (copy-paste)
Four DSL grammar blocks link the operation's own name at something else.
colGroups.ktandvalueCols.kt— the files these were copied from — correctly self-link, so these four were the odd ones out.frameCols.kt:59,62,65[**`frameCols`**][ColumnsSelectionDsl.colGroups]…[ColumnsSelectionDsl.frameCols]colsOfKind.kt:61,64,67[**`colsOfKind`**][ColumnsSelectionDsl.colGroups]…[ColumnsSelectionDsl.colsOfKind]gather.kt:79[**`notNull`**][Gather.cast](thecastrow above it already linksGather.cast)…[Gather.notNull]all.kt:135[**`After`**][ColumnsSelectionDsl.allAfter]…[ColumnsSelectionDsl.allColsAfter]The
all.ktBefore/After/From/UpTofragments are shared by the.all(…)and.allCols(…)grammar rows;Before,FromandUpToall point at theallCols*variant, soAfterwas the only one pointing atallAfter.allColsAfter,frameColsandcolsOfKindare all members of their DSL interfaces, exactly like theallColsBefore/colGroupslinks that already resolve.Broken markdown spans
gather.kt:254—// Assuming `resultA` contains `Double` values and `/// resultB` contains `List<Double>` values,had the backtick on the wrong side of the line break, soresultBwas never a code span and the rest of the line rendered as code. Rewrapped asvalues/and `resultB` contains ….insert.kt:43,177(and the same two lines quoted verbatim inKDOC_GUIDELINES.md:333,339) —[at][InsertClause.at]- inserts a new column …was missing the space before the dash that theunderandafterbullets above it both have.Python-style booleans in a Kotlin KDoc
typeConversions.kt,NullabilityOptions:Infer—set [DataColumn.hasNulls] to true … On empty dataset use False.→to `true` … On an empty dataset, use `false`.Widening—Change False to True if column should be not nullable …→Change `false` to `true` if the column …Checking—Set … to expected value. Throw exception if column should be …→to the expected value. Throws an exception if the column should be …Grammar
Wrong word / missing verb
insert.kt:37—does not immediately insert the new column but instead specify a column to insert→specifies.move.kt:45,group.kt:31,rename.kt:39andconvert.kt:98all write… but instead selects …, so this was the one sentence of the family left disagreeing with its subject.typeConversions.kt:305—@return if column should be marked nullable …opened a@returnon a conditionalif→@return whether the column should be marked nullable …, with the sentence rewrapped under 120 columns.Geocoder.kt:26—Experimental geo coding utility.→geocoding, matching thegeocodepackage and theGeocodername.Suspended hyphens (a Dutch/German convention, not an English one — same class of fix as
-types/decimal-,in #2161)apiLevels.md:170—column names and -types at compile-time→names and types. This exact hunk was part of [AIR] Fixed typos, grammar and a wrong Maven example link in docs and KDocs #2161 but is not inmaster, so it is redone here.KDOC_GUIDELINES.md:201—Some of KDoc-helpers can be used both as -snippets and -topics.→Some KDoc-helpers can be used both as snippets and as topics.Missing articles
sliceRows.md:51,77,103,117,144,181andhead.md:5— the seven one-line summaries oftake/takeLast/takeWhile/drop/dropLast/dropWhile/headall readcontaining first n rows/except last n rows. Added the missingtheand the missing sentence-final period (quickstart.md:537already writesthe first n rows).read.kt:34,write.kt:33(geo) —deprecated "crs" field is used/written for now→the deprecated "crs" field …; thewrite.ktnote also ended its last sentence on a semicolon, now a period.Integration.kt:371—that should not be shown to user in Jupyter variables view→to the user in the Jupyter variables view.Misleading / inconsistent
insert.kt:170—InsertClauseis described asa transitional step before specifying how to insert the selected columns, butinserttakes exactly one column and the clause chooses its placement, not the columns (the next line of the same KDoc already says "with an inserted column") →before specifying where to insert the new column.read.kt:25(geo) —from the input file :had a stray space before the colon.Integration.kt:262—Our integration declares script and css definition. But … That's why we include them directly→script and CSS definitions.plus a comma splice fixed (in IFrames, that's why …);csswas the only lowercase occurrence againstCSS definitionselsewhere. Rewrapped to stay under 120 columns.Verification
**N**umber, anduntillin the deadplugins/kotlin-dataframelegacy copy), so this round is prose- and link-level.src/mainKotlin file: the only remaining name/target mismatches are the deliberate ones where a grammar row splits a function name across fragments (all+Before,name+Starts+With,drop+Last+While, …).allColsAfter,frameColsandcolsOfKindwere each read off their declarations, not inferred.*.mdlink and anchor indocs/StardustDocs/topics/**against the tree (file targets and generated heading slugs): no missing file, no missing anchor, before or after the change.<!---FUN-->/<!---IMPORT-->/<!---END-->blocks the CI bot regenerates, by intersecting the changed line numbers from the diff with each file's block ranges (0 hits).*.ktfiles contains only comment and KDoc lines. No line this PR adds to a Kotlin file exceeds the 120-column limit — three were rewrapped to stay inside it (typeConversions.kt×2,Integration.kt); the long lines flagged in these files are pre-existing and untouched.apiLevels.md:170was left intact, so the markdown line break renders unchanged —git diff --checkflags exactly that one line, and the removed and added sides both end in a space.generated-sourcescopies of the touched KoDEx modules (core,dataframe-geo) are intentionally left alone — the CI bot regenerates and auto-commits them.dataframe-jupyterand the rootKDOC_GUIDELINES.mdhave no generated copy.org.gradle.toolchains.foojay-resolver-convention:1.0.0fails even with--offline), soktlintand the tests were not executed here. The manual comment-only and line-length checks above stand in for the ktlint rules that could apply to this diff.Produced by Air Automations. Name: Bi-weekly Grammar Nazi / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/a9009d9e-63e7-4730-801c-185f5785b6bd?run=c823a9eb-4516-43b1-b6d0-ae32e6cce51b
🤖 Generated with Claude Code