Fix 'Delete' toggle button in Auto Approve settings - issue #4485 #4749
+72
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the "Delete" toggle button in the Auto Approve settings was inactive.
Previously, the toggle appeared disabled because its state prop was not correctly propagated from the main settings view, and changes were not being saved to the extension's global state.
SettingsView.tsx:
Added alwaysAllowDelete to the state destructuring.
Updated the handleSubmit (Save) logic to include alwaysAllowDelete in the payload sent to the extension host.
Ensured the prop is correctly passed to the AutoApproveSettings component.
ExtensionStateContext.tsx:
Initialized alwaysAllowDelete with a safe default of false within the global extension state.
AutoApproveSettings.tsx:
Updated the component to receive the alwaysAllowDelete prop and forward it to the AutoApproveToggle component, enabling the UI interaction.
Manual Testing: Confirmed the Delete button is now active, clickable, and its state persists after clicking "Done" and reloading the extension.