Skip to content

Conversation

@lgrgic
Copy link

@lgrgic lgrgic commented Jan 1, 2026

This PR fixes an issue where the "Delete" toggle button in the Auto Approve settings was inactive.

Previously, the toggle appeared disabled because its state prop was not correctly propagated from the main settings view, and changes were not being saved to the extension's global state.

SettingsView.tsx:
Added alwaysAllowDelete to the state destructuring.
Updated the handleSubmit (Save) logic to include alwaysAllowDelete in the payload sent to the extension host.
Ensured the prop is correctly passed to the AutoApproveSettings component.

ExtensionStateContext.tsx:
Initialized alwaysAllowDelete with a safe default of false within the global extension state.

AutoApproveSettings.tsx:
Updated the component to receive the alwaysAllowDelete prop and forward it to the AutoApproveToggle component, enabling the UI interaction.

Manual Testing: Confirmed the Delete button is now active, clickable, and its state persists after clicking "Done" and reloading the extension.

Screenshot 2026-01-01 at 23 16 55 Screenshot 2026-01-01 at 23 18 35 Screenshot 2026-01-01 at 23 19 31

…tate persistence and adding unit tests for file deletion auto-approval logic. Issue Kilo-Org#4485
@changeset-bot
Copy link

changeset-bot bot commented Jan 1, 2026

⚠️ No Changeset found

Latest commit: 1eee34e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lgrgic lgrgic changed the title Fixed the 'Delete' toggle button in Auto Approve settings - issue #4485 Fix the 'Delete' toggle button in Auto Approve settings - issue #4485 Jan 1, 2026
@lgrgic lgrgic changed the title Fix the 'Delete' toggle button in Auto Approve settings - issue #4485 Fix 'Delete' toggle button in Auto Approve settings - issue #4485 Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant