Skip to content

Conversation

@marius-kilocode
Copy link
Contributor

@marius-kilocode marius-kilocode commented Dec 30, 2025

Adds tab autocomplete support for the /mode command in the CLI, matching the existing autocomplete behavior for /model.

image

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2025

🦋 Changeset detected

Latest commit: 1e7860a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kiloconnect
Copy link
Contributor

kiloconnect bot commented Dec 30, 2025

⚠️ 2 Issues Found

Severity Issue Location
WARNING Indentation inconsistency - extra tabs in code block cli/src/state/hooks/useCommandInput.ts:269-296
SUGGESTION Unintended Git LFS hooks committed .husky/_/ files

Recommendation: Address the indentation issue before merge. The husky files should be removed from this PR.

Review Details (10 files)

Files Reviewed:

  • cli/src/commands/mode.ts - Main autocomplete implementation ✅
  • cli/src/commands/core/types.ts - Type addition ✅
  • cli/src/services/autocomplete.ts - Context update ✅
  • cli/src/state/hooks/useCommandInput.ts - Context update (1 issue)
  • cli/src/commands/__tests__/mode.autocomplete.test.ts - New tests ✅
  • .changeset/mode-autocomplete.md - Changeset ✅
  • .husky/_/post-checkout, post-commit, post-merge, pre-push - Unintended files

Checked: Security, bugs, code style, error handling

Summary: The core implementation follows the existing pattern from /model autocomplete and looks correct. The modeAutocompleteProvider properly retrieves custom modes from context and formats suggestions with source labels. Tests are comprehensive.

Fix these issues in Kilo Cloud

@kiloconnect
Copy link
Contributor

kiloconnect bot commented Dec 30, 2025

⚠️ 1 Issue Found

Severity Issue Location
WARNING Indentation inconsistency cli/src/state/hooks/useCommandInput.ts:292

Recommendation: Address the indentation issue before merge

Review Details (6 files)

Files reviewed:

  • .changeset/mode-autocomplete.md - ✅ Appropriate changeset
  • cli/src/commands/__tests__/mode.autocomplete.test.ts - ✅ Comprehensive tests following existing patterns
  • cli/src/commands/core/types.ts - ✅ Type addition is correct
  • cli/src/commands/mode.ts - ✅ Clean refactor with proper autocomplete provider
  • cli/src/services/autocomplete.ts - ✅ Correctly passes customModes through context
  • cli/src/state/hooks/useCommandInput.ts - ⚠️ Indentation issue (1 issue)

Checked: Security, bugs, performance, error handling, code style

Notes:

  • The autocomplete implementation follows the established pattern from /model command
  • The formatSourceLabel function correctly handles all source types including undefined
  • Test structure mirrors model.autocomplete.test.ts appropriately
  • Line 292 has a single tab on what should be an empty line (see inline comment for fix)

Fix these issues in Kilo Cloud

@marius-kilocode marius-kilocode enabled auto-merge (squash) December 30, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants