fix(rewards): guard BeginBlocker against clock regression - #361
Conversation
If ctx.BlockTime() <= schedule.LastReleaseTime (clock skew), BeginBlocker called CalculateReward with a non-positive elapsed duration. This produced a zero or negative coin amount that panicked sdk.NewCoin. Fix: return nil early when block time has not advanced past the last release time, logging the anomaly at ERROR level.
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Summary
Bug:
BeginBlockerhad no guard for the case wherectx.BlockTime() <= schedule.LastReleaseTime. The only time check wasif schedule.LastReleaseTime.IsZero(). If block time did not advance (clock skew, replay, same-millisecond blocks in testing),CalculateRewardwas called with a non-positive elapsed duration, producing a zero or — absent the companionreward.goguard — a negative coin amount that panickedsdk.NewCoin.Fix: Return
nilearly when!ctx.BlockTime().After(schedule.LastReleaseTime), logging the anomaly atERRORfor operator visibility.Files changed
x/rewards/keeper/abci.go