Skip to content

fix(rewards): ChangeSchedule checks net amount instead of total #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
g0spel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rewards): ChangeSchedule checks net amount instead of total #348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions x/rewards/keeper/msg_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,10 @@ func (k msgServer) ChangeSchedule(ctx context.Context, msg *types.MsgChangeSched
return nil, fmt.Errorf("invalid schedule: %w", err)
}

// Check available funds
if err := k.fundsAvailable(sdkCtx, schedule.TotalAmount); err != nil {
// Check available funds: only require pool to cover the remaining (unreleased) amount,
// not the full TotalAmount (which may have been partially released already).
netAmount := schedule.TotalAmount.Sub(schedule.ReleasedAmount)
if err := k.fundsAvailable(sdkCtx, netAmount); err != nil {
return nil, fmt.Errorf("insufficient funds: %w", err)
}

Expand Down
Loading