[CSS] Migrate Explanation styling to CSS Modules #3163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…styling to CSS Modules, keeping legacy styling until LEMS-3815 is completed.
…ngeset): [CSS] Migrate Explanation styling to CSS Modules
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +100 B (+0.02%) Total Size: 498 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (8374028) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3163If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3163If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3163 |
…check for "prefers reduced motion" in CSS and restore it in legacy styling. Adjust unit tests and snapshots accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR converts the Aphrodite styling into standard CSS. However, since this widget uses a Wonder Blocks component and overrides its styling, the legacy Aphrodite code is kept in a separate file to be deleted later (once Wonder Blocks has migrated to CSS Modules).
Issue: LEMS-3818
Test plan:
Regression tests pass