[CSS] Migrate Numeric Input styling to CSS Modules #3162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assName property pass-through in text-input. Update extract-css script to handle stylesheet declarations inside of functional components in addition to the class-based component.
…branch 'main' into LEMS-3524-migrate-aphrodite-to-css-modules-for-numeric-input
…verse CSS parser as a temporary solution until WB has CSS Modules implemented.
…ll aphrodite extract data to its own file. Start debugging conditional expressions in styles.
…onditionalExpression logic to its own function. Make ConditionalExpressions generate a secondary class name and ruleset in output. Consolidate pxToRem references to be consistent throughout.
… handling variations of Conditional Expressions for CSS values. Update Aphrodite extraction to handle conditional classes.
…sue with async exec commands. Tokenize measurement values. Comment out conditional code blocks with a note to handle the conditional setting of styling.
…t Numeric Input styling to CSS Modules, keeping legacy styling until LEMS-3815 is completed.
…hangeset): [CSS] Migrate Numeric Input styling to CSS Modules
…ck changes to CSS extract file (changes in a different PR). Add comment in legacy styling file for easy searchability.
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +217 B (+0.04%) Total Size: 499 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (7b3fe0e) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3162If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3162If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3162 |
… snapshots to account for addition of class name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR converts the Aphrodite styling into standard CSS. However, since this widget uses a Wonder Blocks component and overrides its styling, the legacy Aphrodite code is kept in a separate file to be deleted later (once Wonder Blocks has migrated to CSS Modules).
Issue: LEMS-3524
Test plan:
Regression tests pass