-
Notifications
You must be signed in to change notification settings - Fork 361
Remove string refs from text-list-editor.tsx #3127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nishasy
wants to merge
4
commits into
remove-string-refs-3
Choose a base branch
from
remove-string-refs-4
base: remove-string-refs-3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One part of our modernization erffor is removing string refs. Doing that in `text-list-editor.tsx` here. Note: Most of this was written by Cursor/Claude Sonnet 4.5. Issue: https://khanacademy.atlassian.net/browse/LEMS-369 Test plan: `pnpm jest` Storybook - Check the categorizer, matcher, orderer, plotter, and sorter widgets in the editor demo - `/?path=/story/editors-editorpage--demo`
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
|
Size Change: +14 B (0%) Total Size: 498 kB
ℹ️ View Unchanged
|
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (7984c29) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3127If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3127If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
One part of our modernization erffor is removing string refs.
Doing that in
text-list-editor.tsxhere.Note: Most of this was written by Cursor/Claude Sonnet 4.5.
Issue: https://khanacademy.atlassian.net/browse/LEMS-369
Test plan:
pnpm jestStorybook
/?path=/story/editors-editorpage--demo