Remove string refs from sortable.tsx #3126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One part of our modernization effort is removing string refs. `sortable.tsx` ended up being a more complex case. Updated it in this PR, including: - Removed string refs - Removed findDOMNode - Coverted callback functions to arrow functions so that `this` could still work Note: Most of this was written by Cursor/Claude Sonnet 4.5. Issue: https://khanacademy.atlassian.net/browse/LEMS-369 Test plan: `pnpm jest` Storybook - Check sorter and matcher widgets in demo page: /?path=/story/editors-editorpage--demo
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +186 B (+0.04%) Total Size: 498 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (3521c87) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3126If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3126If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
One part of our modernization effort is removing string refs.
sortable.tsxended up being a more complex case. Updated it in this PR, including:thiscould still workNote: Most of this was written by Cursor/Claude Sonnet 4.5.
Issue: https://khanacademy.atlassian.net/browse/LEMS-369
Test plan:
pnpm jestStorybook