Remove string refs from hints-renderer.tsx #3125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a trial of removing string refs from hints-renderer.tsx. If this looks right, I'll update other instances of string refs to use this approach. Issue: https://khanacademy.atlassian.net/browse/LEMS-369 Test plan: `pnpm jest` Storybook `/?path=/docs/renderers-hints-renderer--docs`
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +67 B (+0.01%) Total Size: 498 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (933f381) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3125If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3125If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3125 |
anakaren-rojas
approved these changes
Dec 16, 2025
| linterContext: PerseusLinter.linterContextDefault, | ||
| }; | ||
|
|
||
| // Store refs to HintRenderer components |
Contributor
There was a problem hiding this comment.
Small suggestion to change to "why" versus "what"
Suggested change
| // Store refs to HintRenderer components | |
| // Refs needed to call focus() and getSerializedState() on individual hints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Just a trial of removing string refs from hints-renderer.tsx.
If this looks right, I'll update other instances of string refs to use this approach.
Issue: https://khanacademy.atlassian.net/browse/LEMS-369
Test plan:
pnpm jestStorybook
/?path=/docs/renderers-hints-renderer--docs