Skip to content

Fix Kerneta Python packaging and update/watch imports - #72

Open
jaredchu wants to merge 1 commit into
Kerneta:mainfrom
jaredchu:codex/fix-kerneta-packaging-cli
Open

jaredchu wants to merge 1 commit into
Kerneta:mainfrom
jaredchu:codex/fix-kerneta-packaging-cli

Conversation

@jaredchu

Copy link
Copy Markdown

What this changes

Fixes the Python package and CLI failures reported in #70 and #71:

  • Explicitly package the mapped kerneta_engine directory so wheels and source distributions include the engine.
  • Add the engine directory to the CLI import path before running engine scripts, allowing update and watch to resolve their sibling imports.
  • Add five isolated regression tests covering distribution contents, installed doctor, an actual build/update edit, watch detecting an edit and stopping on SIGINT, and source CLI fallback.
  • Add Python CI on Ubuntu and macOS with Python 3.10 and 3.12. Refresh the three existing manifest hashes affected by these changes.

Why

Installed wheels currently omit the engine (#70). With the engine present, update and watch fail on flat sibling imports (#71). The regressions build distributions from copied source and exercise the installed CLI from an unrelated directory in a fresh environment.

Fixes #70. Fixes #71.

Validation

  • All five Python tests passed on macOS with Python 3.10 and 3.12, and independently on Linux arm64 with Python 3.10.
  • Restoring broken package discovery caused four expected regression failures; removing the CLI import-path fix caused three.
  • npm run check: 18 passed; npm run verify: 916 passed; mock npm run selftest: 14 passed. Published-number check found no drift.
  • The existing Node CI job is unchanged. The new hosted Python matrix will cover x64 runners; local Linux validation used arm64.

Checklist

  • Commits are signed off (git commit -s). No CLA, DCO only. See CONTRIBUTING.md.
  • npm run verify and npm run check pass, free and offline.
  • No .dai store, key or *.daidocs-bak file is included (git status checked).

Reader and prompt impact

This patch does not change the reader, ingest prompt or shipped prompts.

Package the mapped engine explicitly and resolve its sibling imports from the CLI. Add isolated distribution and CLI regressions with Python CI.

Signed-off-by: Jared Chu <me@jaredchu.com>
@patricklenert

Copy link
Copy Markdown

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants