Repository navigation
Conversation
Package the mapped engine explicitly and resolve its sibling imports from the CLI. Add isolated distribution and CLI regressions with Python CI. Signed-off-by: Jared Chu <me@jaredchu.com>
|
👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes the Python package and CLI failures reported in #70 and #71:
kerneta_enginedirectory so wheels and source distributions include the engine.updateandwatchto resolve their sibling imports.doctor, an actual build/update edit, watch detecting an edit and stopping on SIGINT, and source CLI fallback.Why
Installed wheels currently omit the engine (#70). With the engine present,
updateandwatchfail on flat sibling imports (#71). The regressions build distributions from copied source and exercise the installed CLI from an unrelated directory in a fresh environment.Fixes #70. Fixes #71.
Validation
npm run check: 18 passed;npm run verify: 916 passed; mocknpm run selftest: 14 passed. Published-number check found no drift.Checklist
git commit -s). No CLA, DCO only. SeeCONTRIBUTING.md.npm run verifyandnpm run checkpass, free and offline..daistore, key or*.daidocs-bakfile is included (git statuschecked).Reader and prompt impact
This patch does not change the reader, ingest prompt or shipped prompts.