First draft of more fine-grained logging#198
Draft
thorehusfeldt wants to merge 1 commit intoKattis:developfrom
Draft
First draft of more fine-grained logging#198thorehusfeldt wants to merge 1 commit intoKattis:developfrom
thorehusfeldt wants to merge 1 commit intoKattis:developfrom
Conversation
Moves most of the functionality from ProblemAspect into various filters, loggers, and handlers in logger.py.
Contributor
|
@thorehusfeldt This needs a rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves most of the functionality from ProblemAspect
into various filters, loggers, and handlers in logger.py.
Why is this good?
/tmpProblemAspect) by decoupling logging (log.error) from problem parts/aspects (self.get_score_range())Why is this bad?
Stuff to think about before moving on:
ProblemAspect._check_resbe moved toInputValidators? Seems to be used only there.ProblemAspect(for instance,verifyproblem.hello.submissions), but one could go all the way down to test case or submission levelverifyproblem.hello.test case group.group 3/045-huge.inorverifyproblem.hello.submissions.ac.th.py.