Skip to content

fix: fonts are index by codepoint #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrentFarris merged 1 commit into from
Jun 26, 2026
+6 −2
Merged

fix: fonts are index by codepoint #861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/rendering/font.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,12 @@ func (cache *FontCache) initFont(face FontFace, adb assets.Database) bool {
cReturn := fontBinChar{letter: '\r', advance: 0.0,
planeBounds: [4]float32{0, 0, 0, 0}, atlasBounds: [4]float32{0.999, 0.001, 1.0, 0.0}}
bin.letters['\r'] = cReturn
for i := int32(0); i < count; i++ {
cache.createLetterMesh(bin, bin.letters[i].letter, bin.letters[i], cache.renderCaches.MeshCache())
// bin.letters is keyed by codepoint (not a dense 0..count-1 array), so range
// over its values to pre-create a mesh for every glyph. Indexing by i would
// only build meshes for codepoints < count, leaving higher glyphs (symbols,
// arrows, geometric shapes) to fall back to the invalidRuneProxy.
for r, fbc := range bin.letters {
cache.createLetterMesh(bin, r, fbc, cache.renderCaches.MeshCache())
}
cache.fontFaces[face.string()] = bin
return true
Expand Down
Loading